| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <8bd0f97a0902271437q7f380e8dl53265832ea240280@mail.gmail.com> Date: Fri, 27 Feb 2009 17:37:09 -0500 From: Mike Frysinger <vapier.adi@...il.com> To: me@...ipebalbi.com Cc: Bryan Wu <cooloney@...nel.org>, felipe.balbi@...ia.com, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] usb: musb: - kill the compile warning On Wed, Feb 25, 2009 at 13:16, Felipe Balbi wrote: > On Fri, Feb 06, 2009 at 06:23:30PM +0800, Bryan Wu wrote: >> drivers/usb/musb/musb_core.c:1433: warning: assignment makes pointer >> from integer without a cast >> hw_ep->target_regs = musb_read_target_reg_base(i, mbase); >> >> static inline u16 musb_read_target_reg_base(u8 i, void __iomem *mbase); >> >> this is a common bug, but a bug still ? mbase is a 32/64 bit pointer, >> but we return a u16 to assign to a pointer ? seems odd :) >> >> So return right pointer in the stub. >> >> Cc: Mike Frysinger <vapier.adi@...il.com> >> Signed-off-by: Bryan Wu <cooloney@...nel.org> > > any new version coming ?? so we're all on the same page ... we agree the first hunk is redundant as MUSB_BUSCTL_OFFSET() is an integer constant and mbase is of the type that is returned. which means the first hunk can be dropped. the 2nd hunk is 100% correct though ... -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists