linux-kernel - [PATCH] Don't profile branches in arm's boot decompressor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1235801574-6417-1-git-send-email-u.kleine-koenig@pengutronix.de>
Date:	Sat, 28 Feb 2009 07:12:54 +0100
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	linux-kernel@...r.kernel.org
Cc:	Steven Rostedt <rostedt@...e.goodmis.org>,
	Ingo Molnar <mingo@...e.hu>, Daniel Walker <dwalker@...o99.com>
Subject: [PATCH] Don't profile branches in arm's boot decompressor

This fixes many compile errors for arch/arm/boot/compressed/misc.c of
the type:

	arch/arm/boot/compressed/misc.c:127: error: section attribute cannot be specified for local variables

The problem is that the branch profiler requires static variables and
arch/arm/boot/compressed/misc.c is compiled with "-Dstatic=".  Anyhow,
there is no big win in profiling boot up code, so simply disable it.

Fix was suggested by Steven Rostedt in #linux-rt.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: Steven Rostedt <rostedt@...e.goodmis.org>
Cc: Ingo Molnar <mingo@...e.hu>
Cc: Daniel Walker <dwalker@...o99.com>
---
 arch/arm/boot/compressed/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile
index fbe5eef..0bcc98c 100644
--- a/arch/arm/boot/compressed/Makefile
+++ b/arch/arm/boot/compressed/Makefile
@@ -89,7 +89,7 @@ LDFLAGS_vmlinux += -p --no-undefined -X \
 
 # Don't allow any static data in misc.o, which
 # would otherwise mess up our GOT table
-CFLAGS_misc.o := -Dstatic=
+CFLAGS_misc.o := -Dstatic= -DDISABLE_BRANCH_PROFILING
 
 $(obj)/vmlinux: $(obj)/vmlinux.lds $(obj)/$(HEAD) $(obj)/piggy.o \
 	 	$(addprefix $(obj)/, $(OBJS)) FORCE
-- 
tg: (db50eec..) t/ftrace/fix-PROFILE_ALL_BRANCHES (depends on: tip/master)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/