linux-kernel - Re: [git-pull -tip] x86: Basic AMD Support for performance counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090228094018.GF12095@elte.hu>
Date:	Sat, 28 Feb 2009 10:40:18 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>,
	x86 maintainers <x86@...nel.org>,
	Paul Mackerras <paulus@...ba.org>
Subject: Re: [git-pull -tip] x86: Basic AMD Support for performance counters


* Jaswinder Singh Rajput <jaswinder@...nel.org> wrote:

> Hello Ingo,
> 
> These patches added basic AMD (K7 and later) support for performance counters:
> 
> [jaswinder@...v5 linux-2.6-tip]$ perfstat -e 0,1,2,3,4,5,-1,-2,-3,-4,-5 ls -lR > /dev/null
> 
>  Performance counter stats for 'ls':
> 
>     2723.203821  task clock ticks     (msecs)
> 
>      1812527794  CPU cycles           (events)
>      1121688997  instructions         (events)
>       569836744  cache references     (events)
>        15934598  cache misses         (events)
>        57313261  branches             (events)
>         4243201  branch misses        (events)
>     2639.682866  cpu clock ticks      (msecs)
>     2723.203821  task clock ticks     (msecs)
>             647  pagefaults           (events)
>            2401  context switches     (events)
>               3  CPU migrations       (events)
> 
>  Wall-clock time elapsed:  6813.030975 msecs

Very nice feature!

The AMD patches look much cleaner than i feared they would be. 
It seems you were able to keep pretty generic x86 code in 
arch/x86/kernel/cpu/perf_counters.c, sharing most of the logic 
between Intel and AMD perfcounters.

> The following changes since commit f39e09b3b2c11ad1b008518a05bc2b7c25eabc7d:
>   Ingo Molnar (1):
>         Merge branch 'tracing/ftrace'
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6-tip.git master
> 
> Jaswinder Singh Rajput (2):
>       x86: prepare perf_counter to add more cpus
>       x86: AMD Support for perf_counter
> 
>  arch/x86/kernel/cpu/amd.c          |    4 +
>  arch/x86/kernel/cpu/perf_counter.c |  189 ++++++++++++++++++++++++++++++------
>  2 files changed, 163 insertions(+), 30 deletions(-)

Pulled into tip:perfcounters/core, thanks Jaswinder!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/