linux-kernel - Re: [PATCH] pci: don't enable too many HT MSI mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 28 Feb 2009 12:57:15 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Prakash Punnoor <prakash@...noor.de>
Cc:	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Robert Hancock <hancockrwd@...il.com>, david@...g.hm,
	Matthew Wilcox <matthew@....cx>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH] pci: don't enable too many HT MSI mapping

On Sat, Feb 28, 2009 at 12:25 AM, Prakash Punnoor <prakash@...noor.de> wrote:
> On Freitag 27 Februar 2009 21:59:08 Yinghai Lu wrote:
>> Prakash Punnoor wrote:
>> > On Dienstag 24 Februar 2009 18:37:35 Jesse Barnes wrote:
>> >> On Monday, February 23, 2009 11:51:59 am Yinghai Lu wrote:
>> >>> Impact: fix bug
>> >>>
>> >>> Prakash reported that his c51-mcp51 system ondie sound card doesn't
>> >>> work MSI but if he hack out the HT-MSI on mcp51, the MSI will work well
>> >>> with sound card.
>> >>>
>> >>> this patch rework the nv_msi_ht_cap_quirk()
>> >>> and will only enable ht_msi on own root device and try to avoid to
>> >>> enable ht_msi on device following that root dev
>> >>>
>> >>> Reported-by: Prakash Punnoor <prakash@...noor.de>
>> >>> Tested-by: Prakash Punnoor <prakash@...noor.de>
>> >>> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
>> >>
>> >> Thanks Yinghai & Prakash, applied this fix to my for-linus branch.
>> >
>> > I am very sorry, but I made a mistake testing this patch. I messed up my
>> > kernels and got a false positive and only noticed this now. The patch
>> > does NOT work and even makes things worse:
>> >
>> > dmesg|grep HT
>> > pci 0000:00:09.0: Found disabled HT MSI Mapping
>> > pci 0000:00:09.0: Enabling HT MSI Mapping
>> > pci 0000:00:09.0: Found enabled HT MSI Mapping
>> > pci 0000:00:09.0: Found enabled HT MSI Mapping
>> > pci 0000:00:09.0: Found enabled HT MSI Mapping
>> > pci 0000:00:09.0: Found enabled HT MSI Mapping
>> >
>> > This is exactly the device which shouldn't be MSI enabled for me. On the
>> > other hand, it doesn't enable the needed devices anymore.
>>
>> please check this one, please power off the system before load the kernel
>> with new patch.
>
> Well, the problem now is that MSI doesn't get enabled on the needed host
> bridge 00.0 (device 10de:02f0), so MSI doesn't work at all on my system (but
> also doesn't hang my system.) I have no idea how to differentiate the 00.0
> device from the "forbidden" 09.0 (device 10de:0270) on my system. Perhaps a
> blacklist is really the best? The original patch by NVidia had a white list,
> btw, see also here:
> http://kerneltrap.org/mailarchive/linux-kernel/2007/11/25/443612/thread
>
> The output of your current patch:
> pci 0000:00:05.0: Boot video device
> pci 0000:00:09.0: Found disabled HT MSI Mapping
> pci 0000:00:0e.0: Enabling HT MSI Mapping
> pci 0000:00:09.0: Found disabled HT MSI Mapping
> pci 0000:00:0f.0: Enabling HT MSI Mapping
> pci 0000:00:09.0: Found disabled HT MSI Mapping
> pci 0000:00:10.0: Enabling HT MSI Mapping
> pci 0000:00:09.0: Found disabled HT MSI Mapping
> pci 0000:00:10.1: Enabling HT MSI Mapping
>
> So, ok, MSI gets enabled on the devices as such (good), not enabled on 09.0
> (good), but also not on the needed host bridge 00.0 (bad).

can you post whole bootlog and lspci -vvxxx and lspci -tv and cat
/proc/interrupts?

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/