linux-kernel - Re: [PATCH] checkpatch: Warn on empty commit log bodies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090228210223.GA23191@sirena.org.uk>
Date:	Sat, 28 Feb 2009 21:02:24 +0000
From:	Mark Brown <broonie@...ena.org.uk>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	Andy Whitcroft <apw@...onical.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: Warn on empty commit log bodies

On Sat, Feb 28, 2009 at 08:25:07PM +0100, Stefan Richter wrote:

> messages.  So if there are people who disregard the patch title for this
> reason, then I dare to say it is because their view is limited by their
> particular MUA and their individual mail reading preferences.  Their

Look, I pretty much agree.  Personally I don't find this a problem.

> > The connection with git is that it doesn't really draw a similar
> > distinction so the issue isn't as immediately obvious when you're
> > working within it. 

> It isn't just a non-obvious issue with git, it is *no issue* with git in
> the first place.  It also is no issue with other patch importing tools

Well, exactly.  There is no issue within git so it's not obvious that
people are going to have a problem when you're working in git.

> Since "Subject = title = beginning of changelog" is the long established
> norm and since the other patch handling tools (and people who handle
> patches) support this norm, checkpatch should follow this convention as
> well and count a non-empty RFC 2822 Subject header as one non-empty
> changelog line.

As I have previously said, that is not the case in reality.  There
appears to be substantial sentiment among people handling patches that
not having any text in the body of the e-mail makes it harder to handle
patches.  I don't have that issue myself but I understand it and it
seems easier to write longer changelogs than to try to change everyone's
workflows.  Quite a few of the one line changelogs could probably
benefit from being expanded a little anyway.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/