linux-kernel - Re: hpsa: SCSI driver for HP Smart Array controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Feb 2009 18:58:57 -0800 (PST)
From:	Stephen Cameron <smcameron@...oo.com>
To:	linux-kernel@...r.kernel.org
Cc:	scameron@...rdog.cca.cpqcorp.net, mike.miller@...com
Subject: Re: hpsa: SCSI driver for HP Smart Array controllers



I see we botched this in hpsa_pci_init()
(one of the last things we changed):

+       if (prod_index == ARRAY_SIZE(products)) {
+               prod_index--;
+               if (subsystem_vendor_id == !PCI_VENDOR_ID_HP ||
+                               !allow_unknown_smartarray) {
+                       printk(KERN_WARNING "hpsa: Sorry, I don't "
+                               "know how to access the Smart "
+                               "Array controller %08lx\n",


That 2nd if should have been, 

if (subsystem_vendor_id != PCI_VENDOR_ID_HP ||

-- steve


      
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/