| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20090301143851.GA11852@srcf.ucam.org> Date: Sun, 1 Mar 2009 14:38:51 +0000 From: Matthew Garrett <mjg59@...f.ucam.org> To: Peter Feuerer <peter@...e.net> Cc: Joe Perches <joe@...ches.com>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] acerhdf: Acer Aspire One fan control Small number of things: *) It looks like the patch has ended up linewrapped - it probably won't apply as a result. *) x86 specific drivers are mostly moving from drivers/misc to drivers/platform/x86. *) It should probably have a DMI modalias to allow it to autoload on appropriate hardware. *) You have user and kernel modes - it should probably also have a bios mode that just leaves fan control in the same state it would be if the driver had never been loaded, and this should be the default. *) The thermal code has been moved from ACPI into the generic thermal layer for 2.6.30. If you register thermal trip points and indicate that you require polling you should be able to get rid of the kernel thread in your driver and leave that up to the kernel. Once that's all dealt with you should submit the patch to linux-kernel and Cc: Len Brown who maintains drivers/platform/x86. Include a description and a signed-off-by: line (and an entry in the MAINTAINERS file) and it should get merged. -- Matthew Garrett | mjg59@...f.ucam.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists