linux-kernel - [PATCHv2] isdn: reduce stack size of mISDN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49AAC180.9000707@suse.de>
Date:	Sun, 01 Mar 2009 18:10:24 +0100
From:	Frank Seidel <fseidel@...e.de>
To:	linux kernel <linux-kernel@...r.kernel.org>
Cc:	akpm@...ux-foundation.org, kkeil@...e.de,
	linux-isdn@...r.kernel.org, Frank Seidel <frank@...eidel.de>,
	Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>,
	Andreas Eversberg <andreas@...rsberg.eu>,
	Hannes Eder <hannes@...neseder.net>,
	Adrian Bunk <bunk@...nel.org>, Frank Seidel <fseidel@...e.de>
Subject: [PATCHv2] isdn: reduce stack size of mISDN_dsp

From: Frank Seidel <frank@...eidel.de>

Reduce stack size memory footprint of mISDN_dsp.
(From 1468 bytes for dsp_cmx_send on i386 down
to 44).

Signed-off-by: Frank Seidel <frank@...eidel.de>
---
 drivers/isdn/mISDN/dsp_cmx.c |   12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

--- a/drivers/isdn/mISDN/dsp_cmx.c
+++ b/drivers/isdn/mISDN/dsp_cmx.c
@@ -1592,13 +1592,21 @@ dsp_cmx_send(void *arg)
 	struct dsp_conf_member *member;
 	struct dsp *dsp;
 	int mustmix, members;
-	s32 mixbuffer[MAX_POLL+100], *c;
+	s32 *mixbuffer;
+	s32 *c;
 	u8 *p, *q;
 	int r, rr;
 	int jittercheck = 0, delay, i;
 	u_long flags;
 	u16 length, count;
 
+	mixbuffer = kmalloc(sizeof(*mixbuffer) * (MAX_POLL + 100), GFP_KERNEL);
+	if (!mixbuffer) {
+		printk(KERN_ERR "mISDN_dsp: cannot allocate buffer(%s)\n",
+		       __func__);
+		return;
+	}
+
 	/* lock */
 	spin_lock_irqsave(&dsp_lock, flags);
 
@@ -1811,6 +1819,8 @@ dsp_cmx_send(void *arg)
 
 	/* unlock */
 	spin_unlock_irqrestore(&dsp_lock, flags);
+
+	kfree(mixbuffer);
 }
 
 /*

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/