lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 28 Feb 2009 21:53:57 -0500
From:	Theodore Tso <tytso@....edu>
To:	Mark Brown <broonie@...ena.org.uk>
Cc:	Stefan Richter <stefanr@...6.in-berlin.de>,
	Andy Whitcroft <apw@...onical.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: Warn on empty commit log bodies

On Sun, Mar 01, 2009 at 12:46:19AM +0000, Mark Brown wrote:
> 
> The reason I sent the patch was that sending changelogs like that for
> trivial changes is getting me negative feedback and I'm seeing other
> comments about "unchangeloged patches" on the lists so I'm pretty sure
> it's not just something I'm doing.  I'm not saying I'm always blameless
> here but when people are using terms like like "unchangeloged" it really
> does suggest that one line changelogs are just considered not to have
> changelogs.

Well, I certainly don't have a problem with this.  I in fact get
*really* *annoyed* when I get patch submissions where the subject line
is replicated in the body, since I then have to manually edit the mail
message before I can run "git am" on the mail message.

Who's been complaining?  I can certainly tell you I'll complain in the
opposite direction, but that's because it actually causes me more work
as a maintainer.  If people are kvetching, maybe they should complain
to git mailing list and ask for a different git commit to e-mail
message convention --- but it's really not hard to look at the subject
line.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists