[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090301001829.GA10751@mit.edu>
Date: Sat, 28 Feb 2009 19:18:29 -0500
From: Theodore Tso <tytso@....edu>
To: Stefan Richter <stefanr@...6.in-berlin.de>
Cc: Mark Brown <broonie@...ena.org.uk>,
Andy Whitcroft <apw@...onical.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: Warn on empty commit log bodies
On Sun, Mar 01, 2009 at 12:01:38AM +0100, Stefan Richter wrote:
> > As I have previously said, that is not the case in reality. There
> > appears to be substantial sentiment among people handling patches that
> > not having any text in the body of the e-mail makes it harder to handle
> > patches.
>
> It is indeed a problem
> - if the patch title alone insufficiently describes the patch
> or
> - if a patch reviewer believes that it is OK to ignore patch titles.
Worse yet, if we start getting these sorts of entries being returned
by "git log":
------------
ext4: Fix spelling error: successfull
Fix spelling error: successfull
Signed-off-by: "Trivial Patch Submitter" <spelling@...s.org>
------------
Just to shut up checkpatch, I'm going to feel the urge to shake a
checkpatch maintainer warmly by the throat.
Sometimes, all that is needed is:
------------
ext4: Fix spelling error: successfull
Signed-off-by: "Trivial Patch Submitter" <spelling@...s.org>
------------
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists