linux-kernel - Re: [PATCH 2/2] GFS2: fix sparse warning: Should it be static?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 02 Mar 2009 12:01:56 +0000
From:	Steven Whitehouse <swhiteho@...hat.com>
To:	Hannes Eder <hannes@...neseder.net>
Cc:	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] GFS2: fix sparse warning: Should it be static?

Hi,

Applied to the -nmw git tree. Thanks,

Steve.

On Sat, 2009-02-21 at 02:12 +0100, Hannes Eder wrote:
> Impact: Make symbol static.
> 
> Fix this sparse warning:
>   fs/gfs2/rgrp.c:188:5: warning: symbol 'gfs2_bitfit' was not declared. Should it be static?
> 
> Signed-off-by: Hannes Eder <hannes@...neseder.net>
> ---
>  fs/gfs2/rgrp.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
> index 34691d7..f03d024 100644
> --- a/fs/gfs2/rgrp.c
> +++ b/fs/gfs2/rgrp.c
> @@ -185,7 +185,8 @@ static inline u64 gfs2_bit_search(const __le64 *ptr, u64 mask, u8 state)
>   * Return: the block number (bitmap buffer scope) that was found
>   */
>  
> -u32 gfs2_bitfit(const u8 *buf, const unsigned int len, u32 goal, u8 state)
> +static u32 gfs2_bitfit(const u8 *buf, const unsigned int len,
> +		       u32 goal, u8 state)
>  {
>  	u32 spoint = (goal << 1) & ((8*sizeof(u64)) - 1);
>  	const __le64 *ptr = ((__le64 *)buf) + (goal >> 5);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/