linux-kernel - Re: [PATCH][retry 2] Conform L3 Cache Index Disable to Linuxstandards From: Eric Lammerts <eric@...merts.org>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090302200213.GA13699@elte.hu>
Date:	Mon, 2 Mar 2009 21:02:13 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	"Langsdorf, Mark" <mark.langsdorf@....com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, tglx@...utronix.de, eric@...merts.org
Subject: Re: [PATCH][retry 2] Conform L3 Cache Index Disable to
	Linuxstandards From:  Eric Lammerts <eric@...merts.org>


* Langsdorf, Mark <mark.langsdorf@....com> wrote:

> > > > Add ABI Documentation entry and fix some /sys directory formating
> > > > issues with the L3 Cache Index Disable feature for future AMD
> > > > processors. __Add a check to disable it for family 0x10 models
> > > > that do not support it yet.
> > > 
> > > x86_64 allnoconfig:
> > > 
> > > arch/x86/kernel/cpu/intel_cacheinfo.c:556: warning: 
> > 'free_cache_attributes' defined but not used
> > > arch/x86/kernel/cpu/intel_cacheinfo.c:596: warning: 
> > 'detect_cache_attributes' defined but not used
> 
> My code doesn't modify either of these functions, so
> I'm not causing the regression.

The more serious problem is what i reported, that your patch 
triggers this build failure:

arch/x86/kernel/built-in.o: In function `store_cache_disable':
intel_cacheinfo.c:(.text+0xd322): undefined reference to `k8_northbridges'
arch/x86/kernel/built-in.o: In function `show_cache_disable':
intel_cacheinfo.c:(.text+0xd52c): undefined reference to `k8_northbridges'

so i've excluded it from tip:master for now. Please resubmit a 
fixed patch.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/