lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 2 Mar 2009 20:38:20 +0000 From: Mark Brown <broonie@...ena.org.uk> To: Theodore Tso <tytso@....edu>, Andrew Morton <akpm@...ux-foundation.org>, Stefan Richter <stefanr@...6.in-berlin.de>, Andy Whitcroft <apw@...onical.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] checkpatch: Warn on empty commit log bodies On Mon, Mar 02, 2009 at 02:57:25PM -0500, Theodore Tso wrote: > If you mean stuff like this: > commit a39a021fd73ce06aad8d1081ac711a36930e6cb8 > Author: Mark Brown <broonie@...nsource.wolfsonmicro.com> > Date: Wed Feb 4 21:10:58 2009 +0100 > > mfd: Mark WM835x USB_SLV_500MA bit as accessible > The code is out of sync with the silicon. > What I wouldn't know, looking at the message, and what I suspect > Andrew is complaining about, is after reading the entire commit log, No, and in fact that's a perfect example of what I'm talking about when I say that simply writing a second paragraph for the commit logs is not a helpful way to deal with the problem here (since it isn't the issue at all). As I've said on a number of occasions already in this thread I am not trying to claim that my commit logs have always been the best or that Andrew was complaining about nothing. I'm perfectly well aware of the sort of things that go into a good commit log, I read quite a lot of them when reviewing patches myself, and do try to provide useful logs even though I don't manage it all the time. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists