linux-kernel - Re: [PATCH 2/2] Input: add wm97xx accelerated driver for AVR32 AT32AP700X microprocessors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49AC5EB2.3050805@gmail.com>
Date:	Mon, 02 Mar 2009 23:33:22 +0100
From:	Jiri Slaby <jirislaby@...il.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Hans-Christian Egtvedt <hcegtvedt@...el.com>
Subject: Re: [PATCH 2/2] Input: add wm97xx accelerated driver for AVR32 AT32AP700X
 microprocessors

On 2.3.2009 15:34, Jiri Slaby wrote:
>> +static int at32_wm97xx_suspend(struct platform_device *pdev,
>> pm_message_t msg)
>> +{
>> + struct at32_wm97xx *at32_wm97xx = platform_get_drvdata(pdev);
>> +
>> + ac97c_writel(at32_wm97xx, IDR, AC97C_INT_CBEVT);
>> + disable_irq(at32_wm97xx->gpio_irq);
>
> Here, you should call disable_irq_sync() (that's what I meant by _sync
> in the last post).

Ah, it's in the opposite way. This one is fine, the patch 1/2 should use 
disable_irq_nosync(), if I understand the code correctly.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/