linux-kernel - Re: [PATCH RFT] MMC: core/core.c: mmc_rescan detects card change in one run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 Mar 2009 09:55:30 +0100
From:	Pierre Ossman <drzeus-mmc@...eus.cx>
To:	Jörg Schummer <ext-jorg.2.schummer@...ia.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFT] MMC: core/core.c: mmc_rescan detects card change in
 one run

On Tue, 03 Mar 2009 09:24:19 +0200
Jörg Schummer <ext-jorg.2.schummer@...ia.com> wrote:

> > 
> > The else section got a bit small here with that code removed. Perhaps
> > we should instead have:
> > 
> > 	if (host->bus_ops != NULL) {
> > 		mmc_bus_put(host);
> > 		goto out;
> > 	}
> 
> I guess you meant
> 
> 	else {
> 		mmc_bus_put(host);
> 		goto out;
> 	}
> 
> since it would be the else clause of
> 
> 	if (host->bus_ops == NULL)
> 

No, I meant to put it further up and unindent the detection code.
Basically you'll be reversing the if-else blocks, but using a goto
instead of an else.

Rgds
-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  rdesktop, core developer          http://www.rdesktop.org

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/