[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 3 Mar 2009 09:09:50 +0900
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To: Paul Menage <menage@...gle.com>
Cc: Li Zefan <lizf@...fujitsu.com>,
Andrew Morton <akpm@...ux-foundation.org>,
LKML <linux-kernel@...r.kernel.org>,
Linux Containers <containers@...ts.linux-foundation.org>
Subject: Re: [PATCH 0/4] cgroups: show correct file mode
On Mon, 2 Mar 2009 10:19:15 -0800
Paul Menage <menage@...gle.com> wrote:
> On Sun, Mar 1, 2009 at 6:13 PM, Li Zefan <lizf@...fujitsu.com> wrote:
> > Now a cgroup subsystem can set default file mode of its control files,
> > so here is a patchset to correct file mode of each subsystem's files.
>
> I really think that we should be defaulting this based on whether the
> control file has read or write handlers.
>
> Sure, there are special cases like "tasks" that we'd need to set a
> manual value for, but most of these patches would be unnecessary.
>
like this ?
int mode;
if (cft->mode)
mode = cft->mode;
else if (cft->write_xxx || .....)
mode = 0644;
else
mode = 0444;
Thanks,
-Kame
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists