linux-kernel - Re: [PATCH] crc32: remove useless _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 Mar 2009 09:33:15 +0000
From:	Will Newton <will.newton@...il.com>
To:	Thiago Galesi <thiagogalesi@...il.com>
Cc:	Pekka Enberg <penberg@...helsinki.fi>, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crc32: remove useless __pure modifier from functions

On Mon, Mar 2, 2009 at 5:42 PM, Thiago Galesi <thiagogalesi@...il.com> wrote:
>>
>> Hmm. They're not marked as pure in the header files. Does GCC look it up
>> from the object file or something for this...?
>
> I just tested this, the answer is No :(
>
> It only works if it's marked in the header. But when it's marked, it
> works, and redundant calls are optimized.

Did you see any change in size of your kernel with this annotation? It
didn't seem to have any effect as far as I could tell.

There are a number of functions in lib/ code that could be marked
__pure or __attribute_const__ but I'm not sure if it's worth the
effort, for my compiler (gcc 4.2) at least.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/