linux-kernel - Re: [RFC PATCH 2/2] Add virtual "idle" device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 Mar 2009 11:00:04 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Marcin Slusarz <marcin.slusarz@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, linux-input@...r.kernel.org
Subject: Re: [RFC PATCH 2/2] Add virtual "idle" device

On Mon, Mar 2, 2009 at 23:42, Marcin Slusarz <marcin.slusarz@...il.com> wrote:
> --- /dev/null
> +++ b/drivers/char/idle.c
> @@ -0,0 +1,445 @@

> +#ifdef DEBUG
> +#define idle_printk(args...) printk(KERN_DEBUG "IDLEDEV: " args)
> +#else
> +#define idle_printk(args...) do {} while (0)
> +#endif

Please use the standard debug interface, i.e.

#define pr_fmt(fmt) "IDLEDEV: " fmt

and use pr_debug() everywhere, to always have printf()-style format checking.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/