[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 3 Mar 2009 09:20:21 +0900
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To: Paul Menage <menage@...gle.com>
Cc: Li Zefan <lizf@...fujitsu.com>,
Andrew Morton <akpm@...ux-foundation.org>,
LKML <linux-kernel@...r.kernel.org>,
Linux Containers <containers@...ts.linux-foundation.org>
Subject: Re: [PATCH 0/4] cgroups: show correct file mode
On Mon, 2 Mar 2009 16:15:51 -0800
Paul Menage <menage@...gle.com> wrote:
> On Mon, Mar 2, 2009 at 4:09 PM, KAMEZAWA Hiroyuki
> <kamezawa.hiroyu@...fujitsu.com> wrote:
> >
> > int mode;
> > if (cft->mode)
> > mode = cft->mode;
> > else if (cft->write_xxx || .....)
> > mode = 0644;
> > else
> > mode = 0444;
>
> Almost:
>
> int mode;
> if (cft->mode) {
> mode = cft->mode;
> } else {
> if (cft->write_xxx || ....)
> mode |= 0600;
> if (cft->read_xxx || ...)
> mode |= 0444;
> }
>
Oh, I see. But int mode=0, at first ;)
I have no objections but please forgive subsys to set mode=0644 explicitly.
Thanks,
-Kame
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists