linux-kernel - Re: next-20090220: XFS: inconsistent lock state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 Mar 2009 12:02:48 -0500
From:	Christoph Hellwig <hch@...radead.org>
To:	Felix Blyakher <felixb@....com>
Cc:	Eric Sandeen <sandeen@...deen.net>,
	Christoph Hellwig <hch@...radead.org>,
	Alexander Beregalov <a.beregalov@...il.com>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>, xfs@....sgi.com
Subject: Re: next-20090220: XFS: inconsistent lock state

On Tue, Mar 03, 2009 at 10:57:07AM -0600, Felix Blyakher wrote:
> 	if (lock_flags) {
> 		if (!xfs_ilock_nowait(ip, lock_flags)) {
> 			ASSERT(0);
> 			error = EAGAIN;
> 			goto out_destroy;
> 		}
> 	}
> 				
> Or just keep the BUG(); , as it shouldn't happen (we hope).

Ok, let's keep the BUG for now and I'll throw in your error undwinding
fix.  Will resend the series for 2.6.29 patches after QAing them.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/