[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 3 Mar 2009 01:30:31 +0100
From: Ingo Molnar <mingo@...e.hu>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Randy Dunlap <randy.dunlap@...cle.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH mainline] menu: fix embedded menu snafu
* Linus Torvalds <torvalds@...ux-foundation.org> wrote:
> On Mon, 2 Mar 2009, Andrew Morton wrote:
> >
> > This patch causes weird unintended breakage, methinks.
>
> Damn, you're right. It looked obvious, so I already applied it, but I
> clearly shouldn't have.
>
> The whole "if EMBEDDED" thing is totally wrong, because those config
> options very much_do_ exist even when non-embedded, it's just that then
> they always take their default valies.
>
> Thanks for noticing.
probably also explains weird build breakages i've been getting
since i updated to your latest:
CC kernel/futex.o
In file included from kernel/futex.c:61:
kernel/rtmutex_common.h: In function ‘task_has_pi_waiters’:
kernel/rtmutex_common.h:81: error: ‘struct task_struct’ has no
member named ‘pi_waiters’
kernel/rtmutex_common.h: In function ‘task_top_pi_waiter’:
kernel/rtmutex_common.h:87: error: ‘struct task_struct’ has no
member named ‘pi_waiters’
make[1]: *** [kernel/futex.o] Error 1
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists