linux-kernel - Re: [PATCH] rtc-v3020: add ability to access v3020 chip with GPIOs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 Mar 2009 13:08:29 -0800
From:	David Brownell <david-b@...bell.net>
To:	Mike Rapoport <mike@...pulab.co.il>
Cc:	Alessandro Zummo <alessandro.zummo@...ertech.it>,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org,
	raph@...com
Subject: Re: [PATCH] rtc-v3020: add ability to access v3020 chip with GPIOs

On Monday 02 March 2009, Mike Rapoport wrote:
> +
> +#define V3020_CS       0
> +#define V3020_WR       1
> +#define V3020_RD       2
> +#define V3020_IO       3
> +
> +struct v3020_gpio {
> +       const char *name;
> +       unsigned int gpio;
> +};
> +

> +static struct v3020_gpio v3020_gpio[] = {
> +       { "RTC CS", 0 },
> +       { "RTC WR", 0 },
> +       { "RTC RD", 0 },
> +       { "RTC IO", 0 },
> +};

After Andrew's fault path cleanup it looks OK, but I see
no point to that GPIO struct with the name.  You know the
name based on the position, if you ever need one.  Take
that away, and you can add my ack.


Also, best not to have a single static struct; there's
no need to add a driver restriction that there be only
one of these chips in a system.

- Dave



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/