linux-kernel - Re: [PATCH -v2] tracing: lockdep tracepoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49AE6DBC.4060401@gmail.com>
Date:	Wed, 04 Mar 2009 14:02:04 +0200
From:	Török Edwin <edwintorok@...il.com>
To:	Peter Zijlstra <peterz@...radead.org>
CC:	Frederic Weisbecker <fweisbec@...il.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ingo Molnar <mingo@...e.hu>, Jason Baron <jbaron@...hat.com>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -v2] tracing: lockdep tracepoints

On 2009-03-04 13:32, Peter Zijlstra wrote:
> On Wed, 2009-03-04 at 12:23 +0100, Frederic Weisbecker wrote:
>   
>>> ---
>>> Subject: tracing: lockdep tracepoints
>>> From: Peter Zijlstra <a.p.zijlstra@...llo.nl>
>>> Date: Tue Mar 03 22:03:08 CET 2009
>>>
>>> Augment the traces with lock names when lockdep is available:
>>>
>>>  1)               |  down_read_trylock() {
>>>  1)               |    _spin_lock_irqsave() {
>>>  1)               |      /* lock_acquire: name: &sem->wait_lock */
>>>  1)   4.201 us    |    }
>>>  1)               |    _spin_unlock_irqrestore() {
>>>  1)               |      /* lock_release: name: &sem->wait_lock */
>>>       
>> Nice idea.
>> I would just suggest to drop the "name:" since the comment is intuitive enough
>> to figure out what we have after lock_{release,acquire}: 
>>     
>
> Makes sense I guess..
>
> Here goes.. one s/name: //g later

Thanks for working on this.
I just booted a kernel with your patch, and it worked.

When I find some time, I will try to write a locklatency tracer that
uses these tracepoints.

Best regards,
--Edwin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/