linux-kernel - Re: [v2 PATCH 4/4] timers: logic to enable timer migration.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090304165208.GA26432@linux.vnet.ibm.com>
Date:	Wed, 4 Mar 2009 22:22:08 +0530
From:	Arun R Bharadwaj <arun@...ux.vnet.ibm.com>
To:	Daniel Walker <dwalker@...o99.com>
Cc:	linux-kernel@...r.kernel.org, linux-pm@...ts.linux-foundation.org,
	a.p.zijlstra@...llo.nl, ego@...ibm.com, tglx@...utronix.de,
	mingo@...e.hu, andi@...stfloor.org, venkatesh.pallipadi@...el.com,
	vatsa@...ux.vnet.ibm.com, arjan@...radead.org,
	svaidy@...ux.vnet.ibm.com
Subject: Re: [v2 PATCH 4/4] timers: logic to enable timer migration.

* Daniel Walker <dwalker@...o99.com> [2009-03-04 08:33:09]:

> On Wed, 2009-03-04 at 17:49 +0530, Arun R Bharadwaj wrote:
> > @@ -649,6 +650,16 @@ __mod_timer(struct timer_list *timer, un
> >  
> >         new_base = __get_cpu_var(tvec_bases);
> >  
> > +       current_cpu = smp_processor_id();
> > +       preferred_cpu = get_nohz_load_balancer();
> > +       if (enable_timer_migration && !tbase_get_pinned(timer->base)
> > &&
> > +                       idle_cpu(current_cpu) && preferred_cpu != -1)
> > {
> > +               new_base = per_cpu(tvec_bases, preferred_cpu);
> > +               timer_set_base(timer, new_base);
> > +               timer->expires = expires;
> > +               internal_add_timer(new_base, timer);
> > +               goto out_unlock;
> > +       }
> 
> Are you sure this compiles w/ CONFIG_SMP=n ? It looks like
> enable_timer_migration wouldn't exist in that case, but the chunks your
> adding in the timer code are still using it.
> 
> Daniel
>

Hi Daniel,

Thanks for pointing this out. I'll clean this up in my next iteration.

--arun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/