linux-kernel - Re: [PATCH] x86: reserve exact size of mptable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090304195105.GB21488@elte.hu>
Date:	Wed, 4 Mar 2009 20:51:05 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: reserve exact size of mptable


* Yinghai Lu <yinghai@...nel.org> wrote:

> 
> Impact: cleanup
> 
> get the exact size for reserve_bootmem
> 
> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
> 
> ---
>  arch/x86/kernel/mpparse.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Index: linux-2.6/arch/x86/kernel/mpparse.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/kernel/mpparse.c
> +++ linux-2.6/arch/x86/kernel/mpparse.c
> @@ -716,10 +716,10 @@ static int __init smp_scan_config(unsign
>  
>  			if (!reserve)
>  				return 1;
> -			reserve_bootmem_generic(virt_to_phys(mpf), PAGE_SIZE,
> +			reserve_bootmem_generic(virt_to_phys(mpf), sizeof(*mpf),
>  					BOOTMEM_DEFAULT);
>  			if (mpf->physptr) {
> -				unsigned long size = PAGE_SIZE;
> +				unsigned long size = get_mpc_size(mpf->physptr);

I see we use get_mpc_size() here - that function can stay too.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/