linux-kernel - Re: [PATCH] mtd_dataflash: Fix probing of AT45DB321C chips.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200903041253.13414.david-b@pacbell.net>
Date:	Wed, 4 Mar 2009 12:53:12 -0800
From:	David Brownell <david-b@...bell.net>
To:	Will Newton <will.newton@...il.com>
Cc:	"linux-kernel" <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Woodhouse <David.Woodhouse@...el.com>
Subject: Re: [PATCH] mtd_dataflash: Fix probing of AT45DB321C chips.

On Wednesday 04 March 2009, Will Newton wrote:
> Commit 771999b65f79264acde4b855e5d35696eca5e80c broke support for probing
> AT45DB321C flash chips. These chips do not support the "page size" status
> bit, so if we match the JEDEC id return early.
> 
> Signed-off-by: Will Newton <will.newton@...il.com>

Acked-by: David Brownell <dbrownell@...rs.sourceforge.net>

.... these are the *only* such chips with that issue, first
version of the more capable generations of chips.

Out of curiousity, was this observed with a C-rev chip, or
inferred by noticing it was the only chip that could ever
need such an "else" branch?

> ---
>  drivers/mtd/devices/mtd_dataflash.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mtd/devices/mtd_dataflash.c
> b/drivers/mtd/devices/mtd_dataflash.c
> index d44f741..cd4781f 100644
> --- a/drivers/mtd/devices/mtd_dataflash.c
> +++ b/drivers/mtd/devices/mtd_dataflash.c
> @@ -822,6 +822,8 @@ static struct flash_info *__devinit
> jedec_probe(struct spi_device *spi)
>  						return info;
>  				}
>  			}
> +			else
> +				return info;
>  		}
>  	}
> 
> -- 
> 1.5.5.2
> 



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/