linux-kernel - Re: [patch 05/39] sata_nv: give up hardreset on nf2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49ADE37E.1040000@kernel.org>
Date:	Wed, 04 Mar 2009 11:12:14 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Stefan Lippers-Hollmann <s.L-H@....de>
CC:	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	stable@...nel.org, Robert Hancock <hancockr@...w.ca>,
	Jeff Garzik <jgarzik@...hat.com>, saro_v@...mail.it
Subject: Re: [patch 05/39] sata_nv: give up hardreset on nf2

Hello, Stefan.

Stefan Lippers-Hollmann wrote:
> Hi
> 
> On Mittwoch, 18. Februar 2009, Greg KH wrote:
>> 2.6.28-stable review patch.  If anyone has any objections, please let us know.
> [...]
>> From: Tejun Heo <tj@...nel.org>
>>
>> commit 7dac745b8e367c99175b8f0d014d996f0e5ed9e5 upstream.
>>
>> Kernel bz#12176 reports that nf2 hardreset simply doesn't work.  Give
>> up.  Argh...
> 
> Sorry to report this rather late, but I upgraded a remote nforce3 system to
> 2.6.28.7 today, and noticed the following messages repeating continously 
> (reproducable on a different nforce3 system as well):
> 
> ata4: EH pending after 5 tries, giving up
> ata4: EH complete
> ata4: EH pending after 5 tries, giving up
> ata4: EH complete
> 
> Reverting just this patch from 2.6.28.7 lets them disappear again. Likewise
> 2.6.29-rc6-git7 is affected as well - and reverting this patch seems to fix
> the issue there as well. 

This is reported in bko#11615.  I don't quite understand it yet.  The
only thing that should have changed is the use of softreset instead of
hardreset and changing inheritance to nv_generic_ops should have done
exactly that in a very safe way.  Apparently, it didn't.  I'll dig
into what went wrong.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/