linux-kernel - Re: &&//|| typo ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 05 Mar 2009 11:30:36 +0200
From:	Benny Halevy <bhalevy@...asas.com>
To:	Jörg-Volker Peetz <jvpeetz@....de>
CC:	linux-kernel@...r.kernel.org
Subject: Re: &&//|| typo ?

On Feb. 16, 2009, 23:35 +0200, Jörg-Volker Peetz <jvpeetz@....de> wrote:
> Hi,
> 
> inspired by the mail http://lkml.org/lkml/2009/2/15/159
> I did
> 
> grep -Ern '\!=.*\|\|.*\!=' linux-2.6.28.5
> 
> and found the following tests which are always true if the tested variable is
> not NaN:
> 
> linux-2.6.28.5/sound/pci/au88x0/au88x0_core.c:2792:	if ((bits != 8) || (bits != 16))
> 
> linux-2.6.28.5/sound/oss/ad1848.c:283:		if ( (devc->model != MD_1845) ||
> (devc->model != MD_1845_SSCAPE))
> linux-2.6.28.5/sound/oss/ad1848.c:2110:			if (devc->model != MD_1845 ||
> devc->model != MD_1845_SSCAPE)
> 
> linux-2.6.28.5/arch/x86/kvm/vmx.c:1794:	if ((ss.type != 3) || (ss.type != 7))
> linux-2.6.28.5/arch/x86/kvm/vmx.c:1837:	if ((tr.type != 3) || (tr.type != 11))
> /* TODO: Check if guest is in IA32e mode */
> 
> linux-2.6.28.5/net/sunrpc/auth_unix.c:122:	if (cred->uc_uid != acred->uid ||
> cred->uc_gid != acred->gid)

This is OK. The left leg compares uids and the right one - gids.

> 
> linux-2.6.28.5/net/sunrpc/svcauth_unix.c:747:	if (svc_getu32(argv) !=
> htonl(RPC_AUTH_NULL) || svc_getu32(argv) != 0) {
> linux-2.6.28.5/net/sunrpc/svcauth_unix.c:833:	if (svc_getu32(argv) !=
> htonl(RPC_AUTH_NULL) || svc_getu32(argv) != 0) {

These two are fine since svc_getu32 will get the next u32
from the argv kvec every time it's being called.

Benny

> 
> linux-2.6.28.5/net/sunrpc/auth_gss/gss_krb5_seqnum.c:78:	if ((plain[4] !=
> plain[5]) || (plain[4] != plain[6])
> linux-2.6.28.5/net/sunrpc/auth_gss/gss_krb5_seqnum.c:79:				   || (plain[4] !=
> plain[7]))
> 
> linux-2.6.28.5/drivers/block/paride/pf.c:569:		if ((buf[k + offs] != 0x20) ||
> (buf[k + offs] != l))
> 
> already known:
> 
> linux-2.6.28.5/drivers/block/paride/pg.c:425:		if (c != ' ' || c != l)
> 
> linux-2.6.28.5/drivers/block/paride/pt.c:506:		if ((buf[k + offs] != 0x20) ||
> (buf[k + offs] != l))
> 
> linux-2.6.28.5/drivers/misc/sgi-gru/grukservices.c:612:	if (word0 != word1 ||
> word0 != MAGIC) {
> 
> linux-2.6.28.5/drivers/scsi/gvp11.c:283:	if (qq != q || qq != 0xff)	/* should be
> read only, all 1's */
> 
> linux-2.6.28.5/drivers/scsi/FlashPoint.c:6045:				if(bit_cnt != 0 || bit_cnt != 8)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/