[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090305104159.GE32407@elte.hu>
Date: Thu, 5 Mar 2009 11:41:59 +0100
From: Ingo Molnar <mingo@...e.hu>
To: Jens Axboe <jens.axboe@...cle.com>
Cc: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
tglx@...utronix.de, James.Bottomley@...senPartnership.com,
jengelh@...ozas.de, bharrosh@...asas.com,
linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-ide@...r.kernel.org
Subject: Re: [BUG] 2.6.29-rc6-2450cf in scsi_lib.c (was: Large amount of
scsi-sgpool)objects
* Jens Axboe <jens.axboe@...cle.com> wrote:
> > > Totally untested, comments welcome...
> >
> > Yeah, I think that updating bi_seg_front_size and
> > bi_seg_back_size at one place, __blk_recalc_rq_segments, is
> > better. I thought about the same way. But we are already in
> > -rc7 and this must go into mainline now. So I chose a
> > less-intrusive way (similar to what we have done in the
> > past).
> >
> > As you know, the merging code is really complicated and we
> > could overlook stuff easily. ;) It might be better to
> > simplify the merging code a bit.
>
> If someone (Ingo?) is willing to test the last variant, I'd
> much rather add that. It does simplify it (imho), and it kills
> 23 lines while only adding 9. But a quick response would be
> nice, then I can ask Linus to pull it later today.
sure, can give it a whirl.
Note that your patch in this thread does no apply cleanly. Could
you please send a pull request of your latest fixes that i could
pull into tip:out-of-tree for testing purposes?
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists