linux-kernel - Re: [PATCH 3/3] xfs: include header files for prototypes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 Mar 2009 14:39:17 +0100
From:	Christoph Hellwig <hch@....de>
To:	Hannes Eder <hannes@...neseder.net>
Cc:	Felix Blyakher <felixb@....com>, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>
Subject: Re: [PATCH 3/3] xfs: include header files for prototypes

looks good, except for a tiny nit-pick:

> +++ b/fs/xfs/support/debug.c
> @@ -19,6 +19,7 @@
>  #include "debug.h"
>  
>  /* xfs_mount.h drags a lot of crap in, sorry.. */
> +#include "xfs_error.h"
>  #include "xfs_sb.h"
>  #include "xfs_inum.h"
>  #include "xfs_ag.h"

as xfs_mount.h doesn't require xfs_error.h it should be included 
above that comment.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/