linux-kernel - Re: [PATCH 0/3] xfs: fix sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4BC7466E-89A4-44E3-8189-C5531F994D73@sgi.com>
Date:	Thu, 5 Mar 2009 11:43:20 -0600
From:	Felix Blyakher <felixb@....com>
To:	Hannes Eder <hannes@...neseder.net>
Cc:	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
	Christoph Hellwig <hch@....de>
Subject: Re: [PATCH 0/3] xfs: fix sparse warnings


On Mar 4, 2009, at 12:33 PM, Hannes Eder wrote:

> The following series fixes a fair amount of the remaining sparse
> warnings in fs/xfs with !CONFIG_XFS_DEBUG.
>
> With CONFIG_XFS_DEBUG we still got alot of "Should it be static?"
> warnings, but that's a different issue.

Looks good to me with the changes Christoph pointed out.
I'll push it in. Thanks.

Reviewed-by: Felix Blyakher <felixb@....com>

>
>
> ---
> Hannes Eder (3):
>      xfs: include header files for prototypes
>      xfs: make symbols static
>      xfs: move declaration to header file
>
> fs/xfs/linux-2.6/xfs_ioctl.c |    1 +
> fs/xfs/linux-2.6/xfs_super.c |    6 +++---
> fs/xfs/support/debug.c       |    1 +
> fs/xfs/xfs_bmap.c            |    2 +-
> fs/xfs/xfs_da_btree.h        |    1 +
> fs/xfs/xfs_dir2.c            |    2 --
> fs/xfs/xfs_dir2_leaf.c       |    2 +-
> 7 files changed, 8 insertions(+), 7 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/