linux-kernel - Re: [patch 2/2] lockdep: initialize lockdep debugging statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0903051355010.25505@chino.kir.corp.google.com>
Date:	Thu, 5 Mar 2009 13:57:18 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Ingo Molnar <mingo@...e.hu>
cc:	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	"David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 2/2] lockdep: initialize lockdep debugging statistics

On Thu, 5 Mar 2009, Ingo Molnar wrote:

> 
> * Peter Zijlstra <peterz@...radead.org> wrote:
> 
> > On Thu, 2009-03-05 at 02:29 -0800, David Rientjes wrote:
> > > The CONFIG_DEBUG_LOCKDEP statistics need to be initialized with
> > > ATOMIC_INIT(0) since they are of type atomic_t.
> > 
> > And how does ATOMIC_INIT(0) differ from the global/static 
> > storage being initialized to 0?
> > 
> > All I can see this doing it moving the variables from bss to 
> > data for some compilers.
> 

It's actually the opposite for gcc 4.1.1, the debugging symbols are now in 
bss.

> ok, i dropped it for now.
> 

It shouldn't be dropped, the initialization is necessary because we can't 
rely on atomic_t's implementation.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/