linux-kernel - Re: [PATCH v2 15/15] NULL noise: mm/memcontrol.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090305144210.e40ef501.akpm@linux-foundation.org>
Date:	Thu, 5 Mar 2009 14:42:10 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Hannes Eder <hannes@...neseder.net>
Cc:	trivial@...nel.org, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org, kamezawa.hiroyu@...fujitsu.com
Subject: Re: [PATCH v2 15/15] NULL noise: mm/memcontrol.c

On Thu, 05 Mar 2009 20:18:44 +0100
Hannes Eder <hannes@...neseder.net> wrote:

> Fix this sparse warning:
>   mm/memcontrol.c:1637:32: warning: Using plain integer as NULL pointer
> 
> Signed-off-by: Hannes Eder <hannes@...neseder.net>
> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> ---
> v2: other subject, as suggested by Al Viro
> 
>  mm/memcontrol.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 8e4be9c..09d6650 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -1634,7 +1634,7 @@ static int mem_cgroup_force_empty_list(struct mem_cgroup *mem,
>  		pc = list_entry(list->prev, struct page_cgroup, lru);
>  		if (busy == pc) {
>  			list_move(&pc->lru, list);
> -			busy = 0;
> +			busy = NULL;
>  			spin_unlock_irqrestore(&zone->lru_lock, flags);
>  			continue;
>  		}

I have to say that I wish sparse didn't do this.  Initialising a
pointer with literal zero is perfectly clear and is idiomatic C.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/