linux-kernel - Re: [PATCH] pci: don't enable too many HT MSI mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200903060045.13509.prakash@punnoor.de>
Date:	Fri, 6 Mar 2009 00:45:12 +0100
From:	Prakash Punnoor <prakash@...noor.de>
To:	Matthew Wilcox <matthew@....cx>
Cc:	Yinghai Lu <yinghai@...nel.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Robert Hancock <hancockrwd@...il.com>, david@...g.hm,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH] pci: don't enable too many HT MSI mapping

On Donnerstag 05 März 2009 18:15:14 Matthew Wilcox wrote:
> On Wed, Mar 04, 2009 at 08:15:37AM +0100, Prakash Punnoor wrote:
> > 2.6.29-rc7 is released, but the last two patches here in the thread have
> > not been picked up. Why?
>
> Oh, I meant to say ... we're at -rc7.  What is the danger here of this
> fixing your machine but breaking somebody else's?

There is a danger that less host bridges get HT MSI enabled by the quirk -
which might need it after all.

> Is there something we
> can minimally do that fixes your machine today and then put in a patch
> for 30-rc1 that is likely to fix other machines?

Something like this would be minimal and works for me:

--- drivers/pci/quirks.c.old    2009-03-06 00:34:40.996532222 +0100
+++ drivers/pci/quirks.c        2009-03-06 00:37:06.915532269 +0100
@@ -2141,6 +2141,10 @@
        int pos;
        int found;

+       /* Enabling HT MSI mapping on this device breaks MCP51 */
+       if (dev->device == 0x270)
+               return;
+
        /* check if there is HT MSI cap or enabled on this device */
        found = ht_check_msi_mapping(dev);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/