linux-kernel - [tip:x86/urgent] x86, pebs: correct qualifier passed to ds_write_config() from ds_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-73bf1b62f561fc8ecb00e2810efe4fe769f4933e@git.kernel.org>
Date:	Fri, 6 Mar 2009 15:15:36 GMT
From:	Markus Metzger <markus.t.metzger@...el.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	eranian@...glemail.com, markus.t.metzger@...el.com,
	tglx@...utronix.de, mingo@...e.hu
Subject: [tip:x86/urgent] x86, pebs: correct qualifier passed to ds_write_config() from ds_request_pebs()

Commit-ID:  73bf1b62f561fc8ecb00e2810efe4fe769f4933e
Gitweb:     http://git.kernel.org/tip/73bf1b62f561fc8ecb00e2810efe4fe769f4933e
Author:     "Markus Metzger" <markus.t.metzger@...el.com>
AuthorDate: Thu, 5 Mar 2009 08:57:21 +0100
Commit:     Ingo Molnar <mingo@...e.hu>
CommitDate: Fri, 6 Mar 2009 16:13:15 +0100

x86, pebs: correct qualifier passed to ds_write_config() from ds_request_pebs()

ds_write_config() can write the BTS as well as the PEBS part of
the DS config. ds_request_pebs() passes the wrong qualifier, which
results in the wrong configuration to be written.

Reported-by: Stephane Eranian <eranian@...glemail.com>
Signed-off-by: Markus Metzger <markus.t.metzger@...el.com>
LKML-Reference: <20090305085721.A22550@...ona.ch.intel.com>
Signed-off-by: Ingo Molnar <mingo@...e.hu>


---
 arch/x86/kernel/ds.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/ds.c b/arch/x86/kernel/ds.c
index de7cdbd..87b67e3 100644
--- a/arch/x86/kernel/ds.c
+++ b/arch/x86/kernel/ds.c
@@ -729,7 +729,7 @@ struct pebs_tracer *ds_request_pebs(struct task_struct *task,
 
 	spin_unlock_irqrestore(&ds_lock, irq);
 
-	ds_write_config(tracer->ds.context, &tracer->trace.ds, ds_bts);
+	ds_write_config(tracer->ds.context, &tracer->trace.ds, ds_pebs);
 	ds_resume_pebs(tracer);
 
 	return tracer;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/