linux-kernel - [PATCH] cpufreq: Remove KERN_ERR output if nForce2 chipset not found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <ada3adqid5v.fsf@cisco.com>
Date:	Fri, 06 Mar 2009 12:55:56 -0800
From:	Roland Dreier <rdreier@...co.com>
To:	davej@...hat.com, cpufreq@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] cpufreq: Remove KERN_ERR output if nForce2 chipset not found

Distribution kernels are building cpufreq drivers into the kernel to get
faster boot; if the nForce2 driver is built in, then on systems that are
not supported by the driver (ie nearly all current systems), the message

    cpufreq: No nForce2 chipset.

is printed at the KERN_ERR level, which means it goes to the console
even if quiet boot is turned on.

The best way to handle this is just to delete the message, since the
likelihood of it ever being of any use to anyone is very low, and other
cpufreq drivers don't print anything if no matching hardware is found.

Signed-off-by: Roland Dreier <rolandd@...co.com>
---
 arch/x86/kernel/cpu/cpufreq/cpufreq-nforce2.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/cpu/cpufreq/cpufreq-nforce2.c b/arch/x86/kernel/cpu/cpufreq/cpufreq-nforce2.c
index 965ea52..055fca3 100644
--- a/arch/x86/kernel/cpu/cpufreq/cpufreq-nforce2.c
+++ b/arch/x86/kernel/cpu/cpufreq/cpufreq-nforce2.c
@@ -419,10 +419,8 @@ static int __init nforce2_init(void)
 	/* TODO: do we need to detect the processor? */
 
 	/* detect chipset */
-	if (nforce2_detect_chipset()) {
-		printk(KERN_ERR "cpufreq: No nForce2 chipset.\n");
+	if (nforce2_detect_chipset())
 		return -ENODEV;
-	}
 
 	return cpufreq_register_driver(&nforce2_driver);
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/