[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <200903061701.04348.jarod@redhat.com>
Date: Fri, 6 Mar 2009 17:01:03 -0500
From: Jarod Wilson <jarod@...hat.com>
To: Roland Dreier <rdreier@...co.com>
Cc: davej@...hat.com, cpufreq@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: Remove KERN_ERR output if nForce2 chipset not found
On Friday 06 March 2009 16:51:49 Roland Dreier wrote:
> > Nb: Matthew Garrett submitted a similar-but-different patch a week or
> > two ago on the cpufreq list that demoted the message to KERN_INFO.
>
> Sorry, missed that. I considered the demotion to KERN_INFO but a) no
> other cpufreq drivers seem to print anything if the device isn't found
> and b) I can't imagine a realistic case of when the message would *ever*
> be useful.
Good points. I wasn't favoring one or the other 'til now, but simply
returning -ENODEV does indeed seem to be more in line with what other
freq scaling drivers do.
--
Jarod Wilson
jarod@...hat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists