linux-kernel - Re: printk issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adaab7wgabs.fsf@cisco.com>
Date:	Sat, 07 Mar 2009 15:52:23 -0800
From:	Roland Dreier <rdreier@...co.com>
To:	Adrian McMenamin <lkmladrian@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: printk issue - bug?

 > printk("PAGE_SIZE is 0x%X\n", PAGE_SIZE);
 > printk("Offset is 0x%X, PAGE_SIZE is 0x%X, readlen is 0x%X\n", offset,
 > PAGE_SIZE, readlen)
 > 
 > Output is:
 > 
 > [  162.603348] PAGE_SIZE is 0x1000
 > [  162.607473] Offset is 0x0, PAGE_SIZE is 0x0, readlen is 0x1000
 > 
 > ie PAGE_SIZE is incorrectly reported in the second printk (these are
 > consecutive lines of code)
 > 
 > offset is loff_t and readlen is unsigned long.

ie offset is a 64-bit type but the printk format for it is %x, which
presumably only consumes 32 bits on SH4?  Seems like your code is buggy
and you ignored a compiler warning about printk format mismatch?

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/