linux-kernel - Re: [PATCH -mmotm] xpad: fix build error and warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5aa163d00903061949o6de1753ep9fe3fb0fbbaa3c1b@mail.gmail.com>
Date:	Fri, 6 Mar 2009 22:49:20 -0500
From:	Mike Murphy <mamurph@...clemson.edu>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>
Subject: Re: [PATCH -mmotm] xpad: fix build error and warnings

On Thu, Mar 5, 2009 at 9:57 PM, Randy Dunlap <randy.dunlap@...cle.com> wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
>
> Add a dummy xpad_send_led_command() for the case of
> CONFIG_JOYSTICK_XPAD_LEDS=n.  Fixes this build error:
>
> ERROR: "xpad_send_led_command" [drivers/input/joystick/xpad.ko] undefined!
>
> Remove 2 duplicate function prototypes in xpad.h.
>
> Fix these xpad.h warnings:
> drivers/input/joystick/xpad.h:231: warning: 'enum led_brightness' declared inside parameter list
> drivers/input/joystick/xpad.h:231: warning: its scope is only this definition or declaration, which is probably not what you want
> drivers/input/joystick/xpad.h:231: warning: 'struct led_classdev' declared inside parameter list
> drivers/input/joystick/xpad.h:231: warning: 'xpad_led_set' declared 'static' but never defined
>
...

Thanks Randy. I found the prototype for xpad_deinit_output to be
missing and will have a patch shortly. I will also be updating the
out-of-tree distribution of this driver version to match the current
-mm tree version:

http://cirg.cs.clemson.edu/~mamurph/pub/xpad/

Mike
-- 
Mike Murphy
Ph.D. Candidate and NSF Graduate Research Fellow
Clemson University School of Computing
120 McAdams Hall
Clemson, SC 29634-0974 USA
Tel: +1 864.656.2838   Fax: +1 864.656.0145
http://cirg.cs.clemson.edu/~mamurph
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/