linux-kernel - [PATCH] drivers/gpio: fix section mismatch warnings in twl4030-gpio.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun, 8 Mar 2009 20:17:34 +0100
From:	Leonardo Potenza <leo.potenza@...il.com>
To:	kernel-janitors@...r.kernel.org
Cc:	hskinnemoen@...el.com, linux-kernel@...r.kernel.org
Subject: [PATCH] drivers/gpio: fix section mismatch warnings in twl4030-gpio.c

From: Leonardo Potenza <lpotenza@...ind.it>

Removed the __devexit annotation of gpio_twl4030_remove(), in order to suppress the following section mismatch messages:

WARNING: drivers/gpio/built-in.o(.devinit.text+0xa0b): Section mismatch in reference from the function gpio_twl4030_probe() to the function .devexit.text:gpio_twl4030_remove()
The function __devinit gpio_twl4030_probe() references
a function __devexit gpio_twl4030_remove().
This is often seen when error handling in the init function
uses functionality in the exit path.
The fix is often to remove the __devexit annotation of
gpio_twl4030_remove() so it may be used outside an exit section.

WARNING: drivers/built-in.o(.devinit.text+0xa0b): Section mismatch in reference from the function gpio_twl4030_probe() to the function .devexit.text:gpio_twl4030_remove()
The function __devinit gpio_twl4030_probe() references
a function __devexit gpio_twl4030_remove().
This is often seen when error handling in the init function
uses functionality in the exit path.
The fix is often to remove the __devexit annotation of
gpio_twl4030_remove() so it may be used outside an exit section.

WARNING: vmlinux.o(.devinit.text+0x1702): Section mismatch in reference from the function gpio_twl4030_probe() to the function .devexit.text:gpio_twl4030_remove()
The function __devinit gpio_twl4030_probe() references
a function __devexit gpio_twl4030_remove().
This is often seen when error handling in the init function
uses functionality in the exit path.
The fix is often to remove the __devexit annotation of
gpio_twl4030_remove() so it may be used outside an exit section.

Signed-off-by: Leonardo Potenza <lpotenza@...ind.it>
---
Index: linux-2.6/drivers/gpio/twl4030-gpio.c
===================================================================
--- linux-2.6.orig/drivers/gpio/twl4030-gpio.c	2009-03-08 19:23:06.000000000 +0100
+++ linux-2.6/drivers/gpio/twl4030-gpio.c	2009-03-08 20:07:41.000000000 +0100
@@ -460,7 +460,7 @@ no_irqs:
 	return ret;
 }

-static int __devexit gpio_twl4030_remove(struct platform_device *pdev)
+static int gpio_twl4030_remove(struct platform_device *pdev)
 {
 	struct twl4030_gpio_platform_data *pdata = pdev->dev.platform_data;
 	int status;
@@ -493,7 +493,7 @@ static struct platform_driver gpio_twl40
 	.driver.name	= "twl4030_gpio",
 	.driver.owner	= THIS_MODULE,
 	.probe		= gpio_twl4030_probe,
-	.remove		= __devexit_p(gpio_twl4030_remove),
+	.remove		= gpio_twl4030_remove,
 };

 static int __init gpio_twl4030_init(void)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/