linux-kernel - Re: [PATCH 01/10] ide: add ->dma_clear method and remove ->dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49B443F1.7050102@ru.mvista.com>
Date:	Mon, 09 Mar 2009 01:17:21 +0300
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/10] ide: add ->dma_clear method and remove ->dma_timeout
 one

Bartlomiej Zolnierkiewicz wrote:

> All custom ->dma_timeout implementations call the generic one thus it is
> possible to have only an optional method for resetting DMA engine instead:
>
> * Add ->dma_clear method and convert hpt366, pdc202xx_old and sl82c105
>   host drivers to use it.
>
> * Always use ide_dma_timeout() in ide_dma_timeout_retry() and remove
>  ->dma_timeout method.
>
> * Make ide_dma_timeout() static.
>
> There should be no functional changes caused by this patch.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
>   

Acked-by: Sergei Shtylyov <sshtylyov@...mvista.com>

> Index: b/include/linux/ide.h
> ===================================================================
> --- a/include/linux/ide.h
> +++ b/include/linux/ide.h
> @@ -715,8 +715,9 @@ struct ide_dma_ops {
>  	int	(*dma_end)(struct ide_drive_s *);
>  	int	(*dma_test_irq)(struct ide_drive_s *);
>  	void	(*dma_lost_irq)(struct ide_drive_s *);
> +	/* below ones are optional */
>  	int	(*dma_timer_expiry)(struct ide_drive_s *);
> -	void	(*dma_timeout)(struct ide_drive_s *);
> +	void	(*dma_clear)(struct ide_drive_s *);
>  	/*
>  	 * The following method is optional and only required to be
>   

   Perhaps worth removing the words about method being optional now...

>  	 * implemented for the SFF-8038i compatible controllers.
>   

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/