linux-kernel - Re: [PATCH] x86/pci: try to detect host_bridge pci_cfg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090308222804.GA25376@elte.hu>
Date:	Sun, 8 Mar 2009 23:28:04 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Matthew Wilcox <matthew@....cx>, Yinghai Lu <yinghai@...nel.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH] x86/pci: try to detect host_bridge pci_cfg_space


* H. Peter Anvin <hpa@...or.com> wrote:

> Matthew Wilcox wrote:
> > On Sun, Mar 08, 2009 at 02:21:40PM -0700, Yinghai Lu wrote:
> >> Jesse or Matthew, can you pick this patch?
> > 
> > Having reviewed it in light of HPA's comment, I don't have a problem
> > with it:
> > 
> > Reviewed-by: Matthew Wilcox <willy@...ux.intel.com>
> > 
> > However, I don't think it's my place to take this patch while Jesse is
> > away; it doesn't feel like it's needed to be submitted between -rc7 and
> > 2.6.29.  Do you have a reason that it needs to be merged more urgently
> > than 2.6.30-rc1?
> > 
> 
> I didn't see one... I was assuming it was a submission to be 
> pushed upstream during the merge window.
> 
> It doesn't fix a regression, so it doesn't seem to me to be a 
> case for a late -rc merge.  It's hardware enablement, so it 
> *might* qualify for 2.6.29-stable, as far as I understand Greg 
> and Chris' policies.

Yeah. The patch is replacing a slowly-but-surely-bitrotting and 
always-behind quirk table with a more generic 
approach/workaround.

So there's no regression technically - but non-fully-working 
cards are obviously quite annoying on new systems. So i'd 
suggest a .30 merge with a Cc: <stable@...nel.org> tag.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/