linux-kernel - Re: [PATCH 2/2] x86: unify noexec handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 8 Mar 2009 10:27:28 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Pekka Enberg <penberg@...helsinki.fi>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org,
	Yinghai Lu <yinghai@...nel.org>
Subject: Re: [PATCH 2/2] x86: unify noexec handling


* Pekka Enberg <penberg@...helsinki.fi> wrote:

> From: Pekka Enberg <penberg@...helsinki.fi>
> 
> Impact: cleanup
> 
> This patch unifies noexec handling on 32-bit and 64-bit.
> 
> Signed-off-by: Pekka Enberg <penberg@...helsinki.fi>
> ---
>  arch/x86/include/asm/pgtable_types.h |    1 -
>  arch/x86/mm/init.c                   |   65 ++++++++++++++++++++++++++++++++--
>  arch/x86/mm/init_32.c                |   50 --------------------------
>  arch/x86/mm/init_64.c                |   33 -----------------
>  4 files changed, 62 insertions(+), 87 deletions(-)

Something around these patches broke CPU hotplug, this sequence 
causes an insta-reboot:

echo 0 > /sys/devices/system/cpu/cpu1/online
echo 1 > /sys/devices/system/cpu/cpu1/online
echo 0 > /sys/devices/system/cpu/cpu1/online
echo 1 > /sys/devices/system/cpu/cpu1/online

i've narrowed the breakage down to:

cd53cc2: Merge branch 'x86/mm'
5ed3468: x86: fix warning about nodeid
b517d59: x86: unify noexec handling, fix
633e9bf: Merge branch 'x86/mm'
ac4d3bf: x86: init_memory_mapping() PSE and PGE setup ifdef removal
ffc442a: x86: unify noexec handling
5dd61df: x86: rename do_not_nx to disable_nx in mm/init_64.c
c77a3b5: x86: fix uninitialized variable in init_memory_mapping()

Config attached.

The last kernel messages that still make it to the serial log 
before the triple fault is:

[   38.331452] CPU0 attaching NULL sched-domain.
[   38.387622] lockdep: fixing up alternatives.
[   38.391965] SMP alternatives: switching to SMP code
[   38.567149] Booting processor 1 APIC 0x1 ip 0x6000
[ reboot ]

	Ingo

View attachment "config" of type "text/plain" (89420 bytes)