linux-kernel - RE: [alsa-devel] [PATCH 2/5] ASoC: ssm2602 codec: fix bug - kernelwill crash when record and play in bf527-ezkit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0F1B54C89D5F954D8535DB252AF412FA03AB85FE@chinexm1.ad.analog.com>
Date:	Mon, 9 Mar 2009 19:07:26 +0800
From:	"Cai, Cliff" <Cliff.Cai@...log.com>
To:	"Mark Brown" <broonie@...ena.org.uk>,
	"Bryan Wu" <cooloney@...nel.org>
Cc:	<alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [alsa-devel] [PATCH 2/5] ASoC: ssm2602 codec: fix bug - kernelwill crash when record and play in bf527-ezkit


 This patch should be named :set constraint only if the value is not 0.
 I found that sometimes substream may be not NULL,but runtime can be
NULL,So the previous way will cause
Kernel to crash.

Cliff

>-----Original Message-----
>From: Mark Brown [mailto:broonie@...ena.org.uk] 
>Sent: Friday, March 06, 2009 8:35 PM
>To: Bryan Wu
>Cc: Cliff Cai; alsa-devel@...a-project.org; 
>linux-kernel@...r.kernel.org
>Subject: Re: [alsa-devel] [PATCH 2/5] ASoC: ssm2602 codec: fix 
>bug - kernelwill crash when record and play in bf527-ezkit
>
>On Fri, Mar 06, 2009 at 03:53:27PM +0800, Bryan Wu wrote:
>
>> set constraint only if the value is not 0, change the 
>configuring way 
>> for sport
>
>This changelog doesn't appear to apply to this patch - it 
>looks like was copied from the previous one?  This patch 
>appears to suffer from a similar issue where only the first 
>format set by an application can ever be used, though since 
>this changes the constraints that are set by the driver 
>there's no possibility that applications will end up trying to 
>use a sample format that the hardware is not configured for.
>
>Do we really need such a heavy handed fix here - what is the 
>issue that's being fixed?
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/