linux-kernel - Re: [PATCH 08/10] ide: move ide_map_sg() call out from ->dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 09 Mar 2009 17:42:43 +0300
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/10] ide: move ide_map_sg() call out from ->dma_setup
 method

Bartlomiej Zolnierkiewicz wrote:

> Move ide_map_sg() call from ->dma_setup implementations
> and ide_destroy_dmatable() one from *_build_dmatable() to
> ide_dma_prepare().
>
> There should be no functional changes caused by this patch.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
>   
[...]
> Index: b/drivers/ide/au1xxx-ide.c
> ===================================================================
> --- a/drivers/ide/au1xxx-ide.c
> +++ b/drivers/ide/au1xxx-ide.c
> @@ -272,9 +272,7 @@ static int auide_build_dmatable(ide_driv
>  	if (count)
>  		return 1;
>  
> - use_pio_instead:
> -	ide_destroy_dmatable(drive);
> -
> +use_pio_instead:
>   

   Could you please get rid of goto and label too, while at it?

> Index: b/drivers/ide/pmac.c
> ===================================================================
> --- a/drivers/ide/pmac.c
> +++ b/drivers/ide/pmac.c
> @@ -1493,8 +1493,6 @@ static int pmac_ide_build_dmatable(ide_d
>  	printk(KERN_DEBUG "%s: empty DMA table?\n", drive->name);
>  
>  use_pio_instead:
> -	ide_destroy_dmatable(drive);
> -
>  	return 0; /* revert to PIO for this request */

   Ditto...

> Index: b/drivers/ide/sgiioc4.c
> ===================================================================
> --- a/drivers/ide/sgiioc4.c
> +++ b/drivers/ide/sgiioc4.c
> @@ -478,8 +478,6 @@ static int sgiioc4_build_dmatable(ide_dr
>  	}
>  
>  use_pio_instead:
> -	ide_destroy_dmatable(drive);
> -
>  	return 0;		/* revert to PIO for this request */
>   

   Ditto...

MBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/