linux-kernel - Re: [PATCH v2] add function spin_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49B536F4.9060609@freescale.com>
Date:	Mon, 09 Mar 2009 10:34:12 -0500
From:	Timur Tabi <timur@...escale.com>
To:	Will Newton <will.newton@...il.com>
CC:	linux-kernel@...r.kernel.org, rdreier@...co.com,
	jirislaby@...il.com
Subject: Re: [PATCH v2] add function spin_event_timeout()

Will Newton wrote:

> Are you sure you want to evaluate condition a second time when
> returning? Some memory mapped registers don't have a stable value so
> e.g. the first test could succeed but the return value could still be
> zero.

Ah, good point.  I was hoping to keep the loop simple by combining the
two test conditions, but I guess that's not going to work.

v3 coming up.

-- 
Timur Tabi
Linux kernel developer at Freescale
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/