linux-kernel - Re: [PATCH 0/5] WM97xx updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090309164846.75152a9a@hcegtvedt>
Date:	Mon, 9 Mar 2009 16:48:46 +0100
From:	Hans-Christian Egtvedt <hans-christian.egtvedt@...el.com>
To:	Hans-Christian Egtvedt <hans-christian.egtvedt@...el.com>
Cc:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Jiri Slaby <jirislaby@...il.com>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Hans-Christian Egtvedt <hcegtvedt@...el.com>
Subject: Re: [PATCH 0/5] WM97xx updates

On Wed, 04 Mar 2009 12:29:03 +0100
Hans-Christian Egtvedt <hans-christian.egtvedt@...el.com> wrote:

> Mark Brown wrote:
> > On Wed, Mar 04, 2009 at 10:26:07AM +0100, Hans-Christian Egtvedt
> > wrote:
> > 
> >> The only thing catched by review was a leaking irq line, do you
> >> plan to fixup that Mark?
> > 

I fixed that in the attached patch, along with using an irqreturn_t
instead of an int for the return value from the interrupt handler.

> > Jiri also had some further comments from the initial posting (mail
> > attached).  I can probably try to fix up most things blind but I'll
> > need to at least set up an at32 toolchain to build test.  The
> > workqueue thing might be better to test on hardware, though, just
> > in case there's some noticable performance impact.  I wouldn't
> > expect so but it'd be safer.
> > 
> 
> I'll see what I can manage to squeeze in of testing, there is always
> the in-between-time.
> 

Please see attached patch. A bit unsure if I should have done an
incremental instead. Mark?

I also made the driver more generic, as it should work fine on AT91
devices as well. AT91 and AVR32 share the same AC97C module.

> What is this patch based against? Linus tree, master branch?
> 

This is against my master branch, but it managed to accept the original
patch so I guess it should go okay the other way as well. Sorry for the
inconvenience.

-- 
Best regards,
Hans-Christian Egtvedt
View attachment "0001-Input-add-wm97xx-accelerated-driver-for-Atmel-micro.patch" of type "text/x-patch" (15327 bytes)