[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090309193901.GA15011@kroah.com>
Date: Mon, 9 Mar 2009 12:39:01 -0700
From: Greg KH <greg@...ah.com>
To: Yu Zhao <yu.zhao@...el.com>
Cc: Matthew Wilcox <matthew@....cx>,
"jbarnes@...tuousgeek.org" <jbarnes@...tuousgeek.org>,
"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
"kvm@...r.kernel.org" <kvm@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"Randy.Dunlap" <rdunlap@...otime.net>
Subject: Re: [PATCH v10 4/7] PCI: add SR-IOV API for Physical Function
driver
On Mon, Mar 09, 2009 at 04:25:05PM +0800, Yu Zhao wrote:
> > > + pci_device_add(virtfn, virtfn->bus);
> >
> > Greg is probably going to ding you here for adding the device, then
> > creating the symlinks. I believe it's now best practice to create the
> > symlinks first, so there's no window where userspace can get confused.
>
> Yes, but unfortunately we can't create links before adding a device.
> I double checked device_add(), there is no place for those links to be
> created before it sends uevent. So for now, we have to trigger another
> uevent for those links.
What exactly are you trying to do with a symlink here that you need to
do it this way? I vaguely remember you mentioning this in the past, but
I thought you had dropped the symlinks after our conversation about this
very problem.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists