linux-kernel - Re: [PATCH] ftrace: fix crash due to tracing of _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090309203836.GA1458@pengutronix.de>
Date:	Mon, 9 Mar 2009 21:38:36 +0100
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	linux-arm-kernel@...ts.arm.linux.org.uk,
	linux-kernel@...r.kernel.org
Cc:	Abhishek Sagar <sagar.abhishek@...il.com>,
	Russell King <linux@....linux.org.uk>,
	Steven Rostedt <rostedt@...e.goodmis.org>,
	Ingo Molnar <mingo@...e.hu>,
	Matthias Kaehlcke <matthias@...hlcke.net>
Subject: Re: [PATCH] ftrace: fix crash due to tracing of __naked functions

Hello,

On Mon, Mar 09, 2009 at 08:46:40AM +0100, Uwe Kleine-König wrote:
> This is a fix for the following crash observed in 2.6.29-rc3:
> http://lkml.org/lkml/2009/1/29/150
> 
> On ARM it doesn't make sense to trace a naked function because then
> mcount is called without stack and frame pointer being set up and there
> is no chance to restore the lr register to the value before mcount was
> called.
> 
> Compared to the original fix posted to arm-linux-kernel ML on 29 Jan
> 2009 by Abhishek Sagar I only changed the definition of __naked for ARM.
while talking on #linux-rt about this patch I noticed that ARM is
currently the only user of __naked.  So maybe making __naked include
notrace unconditionally (as Abhishek suggested) is the right thing to
do.

Russell: Steven considers this patch more ARM than ftrace related, so he
(and probably Ingo, too) would prefer this to go via your tree.  Or at
least they want your Ack.
 
What do you think?

Best regards
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/