linux-kernel - Re: [Aufs 01/25] aufs documents

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090309054842.GA14122@uranus.ravnborg.org>
Date:	Mon, 9 Mar 2009 06:48:42 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	"J. R. Okajima" <hooanon05@...oo.co.jp>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [Aufs 01/25] aufs documents

On Mon, Mar 09, 2009 at 12:24:54PM +0900, J. R. Okajima wrote:
> initial commit
> design and manual
> 
> Signed-off-by: J. R. Okajima <hooanon05@...oo.co.jp>
> ---

Documention seems impressive!
But your changelogs are in the contrary very sparse.

>  fs/Kconfig                                         |    1 +
>  fs/Makefile                                        |    1 +
The changes in the above files breaks bisectability.
You just broke "make oldconfig".


>  fs/namei.c                                         |    4 +-
>  fs/splice.c                                        |   10 +-
>  include/linux/namei.h                              |    3 +
>  include/linux/splice.h                             |    6 +
The changes to files outside fs/aufs2 needs to be justified in your changelog.
And they do not belong in this patch.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/